Draft
Conversation
This change makes the ownership model more clear. Since UniformGrid is a small POD type this seems sensible.
This is one proposed avenue to remove the field creation from the layout.
PCMS follows the language standard requirements of Kokkos. The assumption is that standard that is required by Kokkos will be well supported across the DOE systems.
This Commit addresses three issues: 1. Add Omega_h adapter that handles order 0 and order 1 without MeshFields 2. Gate all calls (CMakeLists.txt, headers, etc.) to MeshFields 3. Add CI test that builds with -DPCMS_ENABLE_MESHFIELDS=OFF
This commit adds a -DPCMS_ENABLE_PETSC=OFF compilation to the CI
This commit removes the create_field.h header and makes use of the Lagrange field factory for the uniform grid evaluations and mask creation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.