Skip to content

LTI1p3: update timezone handling to accomodate Canvas change #1189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bnmnetp merged 1 commit into from
Mar 26, 2026
Merged

LTI1p3: update timezone handling to accomodate Canvas change #1189

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 28 additions & 4 deletions bases/rsptx/admin_server_api/routers/lti1p3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import uuid
import os
import tldextract
from zoneinfo import ZoneInfo

# Third-party imports
# -------------------
Expand All @@ -42,6 +43,7 @@
# -------------------
from rsptx.db.models import (
AuthUserValidator,
Courses,
CoursesValidator,
Lti1p3Conf,
Lti1p3User,
Expand Down Expand Up @@ -461,7 +463,7 @@ async def launch(request: Request):
# make sure RS assignment is up to date (e.g. end date)
course_attributes = await fetch_all_course_attributes(course.id)
await update_rsassignment_from_lti(
rs_assign, assign_lineitem, course_attributes
rs_assign, assign_lineitem, course_attributes, course
)

# start redirect to assignment
Expand Down Expand Up @@ -508,14 +510,34 @@ async def update_lti_assignment_record(


async def update_rsassignment_from_lti(
assign: AssignmentValidator, line_item: LineItem, course_attributes: dict
assign: AssignmentValidator,
line_item: LineItem,
course_attributes: dict,
course: Courses,
) -> AssignmentValidator:
"""
Update a runestone assignment from LTI data.
"""
try:
lms_due_string = line_item.get_end_date_time()
lms_due = datetime.datetime.fromisoformat(lms_due_string)
rslogger.info(
f"LTI1p3 - Received {lms_due_string} for assignment {assign.name}"
)

# Parse ISO datetime. Normalize trailing Z so fromisoformat can parse UTC.
normalized_due_string = (
lms_due_string.replace("Z", "+00:00")
if lms_due_string.endswith("Z")
else lms_due_string
)
lms_due = datetime.datetime.fromisoformat(normalized_due_string)

# If LMS provided timezone info and course has a timezone, convert to course local time.
if lms_due.tzinfo is not None and course.timezone:
lms_due = lms_due.astimezone(ZoneInfo(course.timezone))
rslogger.info(
f"LTI1p3 - Converted to {lms_due} in timezone {course.timezone}"
)
lms_due = lms_due.replace(tzinfo=None)
if (
lms_due is not None
Expand Down Expand Up @@ -1125,7 +1147,9 @@ async def assign_select(launch_id: str, request: Request, course=None):
)
await ags.update_lineitem(line_item)
# update RS due date
await update_rsassignment_from_lti(assign, line_item, course_attributes)
await update_rsassignment_from_lti(
assign, line_item, course_attributes, course
)
deep_link = message_launch.get_deep_link()
response_html = deep_link.output_response_form(response_list)
response = HTMLResponse(content=response_html, status_code=200)
Expand Down
Loading