-
Notifications
You must be signed in to change notification settings - Fork 1
Added namespace concatenation rules #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ayushgnv
wants to merge
3
commits into
RobotecAI:main
Choose a base branch
from
ayushgnv:ayushg/Add_namespace_reqs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+49
−2
Open
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment on no leading
/characters prevents from using absolute namespaces. Personally, I don't necessarily see the need for such namespaces in OpenUSD. On the other hand, such limitation makes this standard less close to what ROS 2 offers.Similarly, we might want to consider allowing tilde characters
~and substitutions{}.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am okay with clarifying that if a leading forward slash is present then we use a absolute namespace.
And perhaps use a different character to indicate this is a compoasable namespace vs absolute.
If there are multiple absolute namespaces in the prim hierarchy, do we resolve to the closest absolute namespace as we traverse from the primary ros pub/sub prim upwards the stage tree?
In Isaac Sim, private namespaces isnt as useful since it is essentially a single ros node that runs the multiple publishers and subscribers.
But if there is a way to include private namespace functionality in this standard I am open to discussions!