Fix #2767: Use text.primary color for h1 headings in markdown blocks#2776
Open
cobyfrombrooklyn-bot wants to merge 1 commit intoRedocly:mainfrom
Open
Fix #2767: Use text.primary color for h1 headings in markdown blocks#2776cobyfrombrooklyn-bot wants to merge 1 commit intoRedocly:mainfrom
cobyfrombrooklyn-bot wants to merge 1 commit intoRedocly:mainfrom
Conversation
H1 headings in markdown blocks incorrectly used colors.primary.main for their text color, while H2 used colors.text.primary. This made H1 headers appear in the primary/accent color instead of the standard text color, breaking visual consistency. Changed h1 color from colors.primary.main to colors.text.primary to match h2 and other heading levels. Added test to verify both h1 and h2 use colors.text.primary. Fixes Redocly#2767
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
H1 headings in markdown blocks incorrectly used
colors.primary.mainfor their text color, while H2 usedcolors.text.primary. This made H1 headers appear in the primary/accent color (e.g. blue#32329f) instead of the standard text color (#333333), breaking visual consistency.Changes
src/components/Markdown/styled.elements.tsxfromcolors.primary.maintocolors.text.primaryTest
Added
src/components/Markdown/__tests__/styled.elements.test.tsxthat:colors.text.primarycolors.text.primarycolors.primary.mainTested locally on macOS ARM (Apple Silicon). Full test suite passes (pre-existing snapshot failures unrelated to this change).
Fixes #2767