-
Notifications
You must be signed in to change notification settings - Fork 44
Addition of new class Space:Wing and ODR. #257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PeteHart
wants to merge
2
commits into
main
Choose a base branch
from
dev/peterhart/wing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
15 changes: 15 additions & 0 deletions
15
OntologyDecisionRecords/ODR 004 Introduction of Space:Wing.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| # ODR 004 Introduction of Space:Wing | ||
|
|
||
| ## Context | ||
|
|
||
| With the release of Brick 1.4 the brick:Location domain will be deprecated in favour of rec:Space. All specific Brick location classes but brick:Wing are already covered in REC. This ODR introduces the building Wing concept in REC for future compatibility reasons. | ||
|
|
||
| ## Decision | ||
|
|
||
| An new class rec:Wing is introduced as subclass to the rec:SubBuilding. | ||
|
PeteHart marked this conversation as resolved.
Outdated
|
||
|
|
||
| ## Consequences | ||
|
|
||
| Applications that uses the brick:Wing class can continue to use the building wing abstraction albeit in the REC namespace as rec:Wing. | ||
|
|
||
| Note; For new application REC recommends to use the rec:SubBuilding generalization of various building components such as towers, wings etc. | ||
File renamed without changes.
12 changes: 12 additions & 0 deletions
12
Source/DTDLv2/RealEstateCore/Space/Architecture/SubBuilding/Wing.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| { | ||
| "@id": "dtmi:org:w3id:rec:Wing;1", | ||
| "@type": "Interface", | ||
| "displayName": { | ||
| "en": "Wing" | ||
| }, | ||
| "comment": { | ||
| "en": "Introduced in REC as Brick is deprecating their location domain. A building may comprise quite many elements such as towers, annexes, rotundas etc. As well as wings. It's difficult to capture all variations in the ontology and REC recommend to use the generalization sub building if possible." | ||
| }, | ||
| "extends": "dtmi:org:w3id:rec:SubBuilding;1", | ||
| "@context": ["dtmi:dtdl:context;2"] | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.