Skip to content

Lazy loading of Julia things #2804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JacksonBurns merged 7 commits into from
Jun 11, 2025
Merged

Lazy loading of Julia things #2804

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d74d075
Lazy loading of Julia in reactionmechanismsimulator_reactors
rwest Jun 3, 2025
d1e6552
Delay loading of Julia in pdep/sls
rwest Jun 4, 2025
53aed2e
Remove the NO_JULIA flag
rwest Jun 4, 2025
01e7032
Remove RMG_DISABLE_JULIA from Makefile
rwest Jun 4, 2025
d48a976
fixup! Delay loading of Julia in pdep/sls
rwest Jun 4, 2025
b2e5704
Rename MainProxy to LazyMain and improve Julia disable checks
rwest Jun 11, 2025
5378e9d
Remove the DISABLE_JULIA option.
rwest Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions rmgpy/pdep/sls.py
View file
Open in desktop
Copy link
Copy Markdown
Member Author

@rwest rwest Jun 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a reminder that testing coverage is big fat 0% for this file.
https://app.codecov.io/gh/ReactionMechanismGenerator/RMG-Py/tree/main/rmgpy%2Fpdep

Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,13 @@
"""

import logging
import sys
import os

import numpy as np
import scipy.linalg
import scipy.optimize as opt
import scipy.sparse as sparse

import rmgpy
import rmgpy.constants as constants
from rmgpy.pdep.me import generate_full_me_matrix, states_to_configurations
from rmgpy.rmg.reactionmechanismsimulator_reactors import to_julia
Expand All @@ -62,10 +62,11 @@ def __getattr__(self, name):
Main.seval("using ReactionMechanismSimulator.SciMLBase")
Main.seval("using ReactionMechanismSimulator.Sundials")
except Exception as e:
logging.error("Failed to import Julia and load ReactionmechanismSimulator components needed.")
logging.error("Failed to import Julia and load ReactionMechanismSimulator components needed.")
raise
globals()['Main'] = JuliaMain # Replace proxy with real thing, for next time it's called
return getattr(JuliaMain, name) # Return the attribute for the first time it's called

Main = MainProxy()


Expand Down
Loading