build: Use Gradle credentials system#6467
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request modernizes the Gradle credentials system by switching from explicit credential configuration to Gradle's built-in PasswordCredentials system for GitHub Packages authentication.
Key Changes:
- Replaced explicit credential blocks with
credentials(PasswordCredentials::class)in build scripts - Updated GitHub Actions workflows to use
ORG_GRADLE_PROJECT_*environment variables - Simplified credential management across both plugin management and publishing repositories
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| settings.gradle.kts | Replaced explicit credential block with PasswordCredentials for plugin repository |
| patches/build.gradle.kts | Replaced explicit credential block with PasswordCredentials for publishing repository |
| .github/workflows/release.yml | Updated to use ORG_GRADLE_PROJECT environment variables instead of GITHUB_TOKEN |
| .github/workflows/build_pull_request.yml | Updated to use ORG_GRADLE_PROJECT environment variables instead of GITHUB_TOKEN |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Please also update the setup docs so we know how to use this new method thanks! |
Whoops, I forgotten about that completely. I'll quickly write it for documentation in a bit. Quick remedy for now you can use this breaking change advisory that I sent to the team. Team notice 0801 (updated: 0901)
Hiiiiii New changes in build configuration that change the credentials system of ReVanced, ReVanced Gradle Credentials based system. To make sure that you weren't affected, (if not already) create githubPackagesUsername=LabubuCrusher
githubPackagesPassword=ghp_PopmartDestoryMigrationIn Global properties at Gradle User Home directory
Diff- gpr.user=LabubuCrusher
- gpr.key=ghp_PopmartDestory
+ githubPackagesUsername=LabubuCrusher
+ githubPackagesPassword=ghp_PopmartDestory |
Switch to PasswordCredentials when during authentication with ghcr
nts:
List of what repository have PR submitted see: ReVanced/revanced-manager-downloaders-template#16 (comment)