Closed
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request modernizes the Gradle authentication mechanism by switching from manual environment variable handling to Gradle's built-in PasswordCredentials system for GitHub Packages authentication.
Key changes:
- Simplified build.gradle.kts by replacing explicit credential configuration with
credentials(PasswordCredentials::class) - Updated GitHub Actions workflows to use Gradle project properties (
ORG_GRADLE_PROJECT_*prefix) instead of direct environment variables - Applied changes consistently across both release and pull request build workflows
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| build.gradle.kts | Switched from explicit username/password credential configuration to Gradle's PasswordCredentials class |
| .github/workflows/release.yml | Updated environment variables to use Gradle project property convention for credentials |
| .github/workflows/build_pull_request.yml | Updated environment variables to use Gradle project property convention for credentials |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
validcube
commented
Jan 9, 2026
Member
|
Implemented in #11 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch to PasswordCredentials when during authentication with ghcr
nts:
List of what repository have PR submitted see: ReVanced/revanced-manager-downloaders-template#16 (comment)