feat: add analytic calls to upload button#1400
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Plausible analytics instrumentation for the Scratch project “Upload” flow to support issue #1247.
Changes:
- Track an analytics event when the Upload button is clicked.
- Track an analytics event when a
.sb3file is selected (Scratch projects only).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
19
to
+32
| const onClickUpload = () => { | ||
| if (window.plausible) { | ||
| window.plausible("Upload project"); | ||
| } | ||
| fileInputRef.current?.click(); | ||
| }; | ||
|
|
||
| const onFileSelected = (event) => { | ||
| const file = event.target.files?.[0]; | ||
| if (!file || project.project_type !== "code_editor_scratch") return; | ||
|
|
||
| if (window.plausible) { | ||
| window.plausible("Upload project - file selected"); | ||
| } |
There was a problem hiding this comment.
New analytics side effects (Plausible events on click and on file selection) are not covered by existing UploadButton tests. Please extend UploadButton.test.js to assert window.plausible is called with the expected event names for both interactions (and reset the mock between tests).
zetter-rpf
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: 1247
Adds analytics calls to Upload button