Skip to content

Add material-symbols-sharp class selector #1398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamiebenstead merged 1 commit into from
Mar 23, 2026
Merged

Add material-symbols-sharp class selector #1398

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/assets/stylesheets/App.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,3 +82,21 @@ body,
::-webkit-scrollbar {
display: none;
}

.material-symbols-sharp {
font-family: "Material Symbols Sharp", sans-serif;
font-weight: normal;
font-style: normal;
font-size: 24px;
line-height: 1;
letter-spacing: normal;
text-transform: none;
display: inline-block;
white-space: nowrap;
overflow-wrap: normal;
direction: ltr;
-webkit-font-smoothing: antialiased;
-moz-osx-font-smoothing: grayscale;
text-rendering: optimizeLegibility;
font-feature-settings: "liga";
}
Comment on lines +86 to +102
Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stylesheet defines the .material-symbols-sharp class, but the repo doesn’t appear to load the "Material Symbols Sharp" font anywhere (no @font-face, no <link> to Google Fonts, and no bundled font asset). Without actually providing the font, this class will fall back to sans-serif and render the icon names as text. Consider adding the font import/bundled font-face (or documenting/enforcing that the host page must load it).

Copilot uses AI. Check for mistakes.
Copy link
Contributor

@zetter-rpf zetter-rpf Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine - we're adding this now because of a user of editor UI (standalone) renders HTML with the plugin system which includes icons.

I think most places we use editor UI the font will be loaded, we could consider adding it in the future if we use the font directly from ui.

Loading