[CK] Add rocm_ck directory structure with feature flag#7090
Open
[CK] Add rocm_ck directory structure with feature flag#7090
Conversation
shumway
force-pushed
the
users/shumway/ck/rocm-ck-dirs
branch
2 times, most recently
from
698a4b0 to
0230b22
Compare
shumway
force-pushed
the
users/shumway/ck/rocm-ck-dirs
branch
2 times, most recently
from
2afddd7 to
a87e201
Compare
shumway
force-pushed
the
users/shumway/ck/rocm-ck-dirs
branch
2 times, most recently
from
86b59b2 to
f4a98df
Compare
chris-tsiaousis-hpc
approved these changes
May 7, 2026
Contributor
chris-tsiaousis-hpc
left a comment
chris-tsiaousis-hpc
left a comment
There was a problem hiding this comment.
LGTM! Thanks for starting this (and starting it this way). Added some considerations but you can view them as NITs.
shumway
force-pushed
the
users/shumway/ck/rocm-ck-dirs
branch
from
f4a98df to
56d5aef
Compare
shumway
commented
May 7, 2026
Contributor
Author
shumway
left a comment
shumway
left a comment
There was a problem hiding this comment.
Thank you for the carful review. I followed up on each of your comments, they were helpful!
…tion Establish the production rocm_ck directory at composablekernel/rocm_ck/, peer to tile_engine/ and dispatcher/. rocm_ck is a constexpr schema API over CK Tile device kernels, enabling host-device separation for multi-architecture distribution. - Add CK_ENABLE_ROCM_CK option (default OFF) gating add_subdirectory - Create INTERFACE library (rocm_ck) and ck_tile_headers target - Add GTest integration with builder-style convenience targets (smoke-rocm-ck, check-rocm-ck) - Add index_t.hpp with unit test verifying type compatibility with ck_tile - Enable RUN_ROCM_CK_TESTS by default in Jenkins (ON in CI, OFF in CMake) - Add README documenting the constexpr schema model and kpack workflow Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Set C++20 on rocm_ck INTERFACE library so all consumers inherit it - Use full relative paths in test list with get_filename_component - Simplify README directory tree to dir-level descriptions Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The global `check` target runs CTest without label filtering, which discovers rocm_ck tests registered via add_test(). But `check` had no dependency on the rocm_ck build targets, so the test executables were never compiled — CTest failed with "Could not find executable." Add build-smoke-rocm-ck as a dependency of check when CK_ENABLE_ROCM_CK is enabled. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
shumway
force-pushed
the
users/shumway/ck/rocm-ck-dirs
branch
from
23b0ea7 to
f11ed26
Compare
chris-tsiaousis-hpc
approved these changes
May 8, 2026
Contributor
chris-tsiaousis-hpc
left a comment
chris-tsiaousis-hpc
left a comment
There was a problem hiding this comment.
LGTM! Thanks for addressing my comments!
CK's -Weverything flag enables -Wc++20-compat, which warns about consteval being incompatible with pre-C++20 — irrelevant since rocm_ck requires C++20. With -Werror this becomes a hard failure on Jenkins. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
aosewski
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds initial rocm_ck directory structure, #7119.
rocm_ck/directory atcomposablekernel/rocm_ck/, peer totile_engine/anddispatcher/CK_ENABLE_ROCM_CKoption (default OFF) as a CK-internal feature flag — no superbuild or TheRock changes neededrocm_ckINTERFACE library,ck_tile_headerstarget, GTest integration with builder-style convenience targets (smoke-rocm-ck,check-rocm-ck)RUN_ROCM_CK_TESTSparameter for CI, following theRUN_BUILDER_TESTSpatternTest plan
cmake -DCK_ENABLE_ROCM_CK=ONconfigures without errorsninja check-rocm-ckpasses (4 host-only index type tests)CK_ENABLE_ROCM_CK=OFF) is unaffected — no rocm_ck targets presentRUN_ROCM_CK_TESTS=trueenables the flag and runscheck-rocm-ck🤖 Generated with Claude Code