Skip to content

Added a warning that shows up if someone wants to build AOMP for the untested targets aarch64 or ppc64le #1014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ThorBl wants to merge 2 commits into
base: aomp-dev
Choose a base branch
from
Open

Added a warning that shows up if someone wants to build AOMP for the untested targets aarch64 or ppc64le #1014

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3095730
Added a warning that shows up if someone wants to build AOMP for the …
ThorBl Jul 31, 2024
7ac5c04
removed "read" and added "sleep" instead. Script will wait for 6 seco…
ThorBl Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions bin/build_project.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,10 @@ REPO_DIR=$AOMP_REPOS/$AOMP_PROJECT_REPO_NAME
patchrepo $REPO_DIR

# End check-openmp prep
if [ "$AOMP_PROC" == "ppc64le" ] || [ "$AOMP_PROC" == "aarch64" ] ; then
echo "WARNING: You are about to build AOMP for the *untested* target $AOMP_PROC. Press enter to continue."
read
Copy link
Contributor

@ronlieb ronlieb Jul 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if someone runs the build and redirects all output to a log file, will this hang waiting for a keyboard response ?

Copy link
Contributor Author

@ThorBl ThorBl Jul 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it will hang. I only tested it with "|& tee". I will use sleep instead.

fi

if [ "$AOMP_PROC" == "ppc64le" ] ; then
COMPILERS="-DCMAKE_C_COMPILER=/usr/bin/gcc-7 -DCMAKE_CXX_COMPILER=/usr/bin/g++-7"
Expand Down