CI: Automating workflow execution for internal contributors only#4825
Closed
Muhamed-Husic wants to merge 2 commits intoROCm:developfrom
Closed
CI: Automating workflow execution for internal contributors only#4825Muhamed-Husic wants to merge 2 commits intoROCm:developfrom
Muhamed-Husic wants to merge 2 commits intoROCm:developfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #4825 +/- ##
===========================================
+ Coverage 92.49% 92.52% +0.02%
===========================================
Files 583 583
Lines 29562 29967 +405
===========================================
+ Hits 27343 27724 +381
- Misses 2219 2243 +24 🚀 New features to boost your workflow:
|
Contributor
Author
|
Closing in favour of #4830 which implements different approach |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The goal of this PR is to make sure untrusted fork contributors can't run performance pipeline without explicit maintainer approval, while trusted contributors (members, collaborators and same repo PRs) run it automatically.
Technical Details
Same repo PRs and trusted contributors now run this workflow automatically without needing
ok-to-testlabel, while untrusted fork contributors still require maintainer approval viaok-to-testlabel before anything runs. Also added new step to handle cases where maintainer approves a fork PR by adding the label, but the contributor then pushes new (potentially malicious) commit before the tests finish. Without this step those new unreviewed commits would run through the pipeline under the cover of previous approval.Changelog Category
Add a
CHANGELOG.mdentry for any option other thanNot Applicable