Skip to content

Add rocprofv3 and att trace library #4797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pfultz2 wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Add rocprofv3 and att trace library #4797

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac1c379
Add rocprofv3 and att trace library
pfultz2 Apr 17, 2026
08f2d91
Remove sudo
pfultz2 Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y --allow-
hipsolver \
rocthrust \
rocrand \
rocprofiler-sdk \
hipsparse \
rccl \
rocm-smi-lib \
Expand All @@ -69,6 +70,7 @@ RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y --allow-
apt-get clean && \
rm -rf /var/lib/apt/lists/*


Copy link

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There’s an extra blank line added here that doesn’t appear to separate logical sections. Consider removing it to keep the Dockerfile formatting consistent.

Suggested change

Copilot uses AI. Check for mistakes.
# Install pytorch
RUN pip3 install https://repo.radeon.com/rocm/manylinux/rocm-rel-7.1.1/torch-2.8.0%2Brocm7.1.1.lw.gitcba8b9d2-cp310-cp310-linux_x86_64.whl\
https://repo.radeon.com/rocm/manylinux/rocm-rel-7.1.1/torchvision-0.24.0%2Brocm7.1.1.gitb919bd0c-cp310-cp310-linux_x86_64.whl\
Expand All @@ -83,6 +85,9 @@ RUN echo "/opt/rocm/lib" > /etc/ld.so.conf.d/rocm.conf
RUN echo "/opt/rocm/llvm/lib" > /etc/ld.so.conf.d/rocm-llvm.conf
RUN ldconfig

# ATT library
RUN sudo wget -O /opt/rocm/lib/librocprof-trace-decoder.so https://github.com/ROCm/rocprof-trace-decoder/raw/refs/heads/amd-mainline/releases/linux_glibc_2_28_x86_64/librocprof-trace-decoder.so
Copy link

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sudo is used in this RUN step, but the Dockerfile never installs sudo and the build runs as root by default (no USER set). This will fail with sudo: not found; drop sudo (or explicitly install it / switch users if that’s intended).

Suggested change
RUN sudo wget -O /opt/rocm/lib/librocprof-trace-decoder.so https://github.com/ROCm/rocprof-trace-decoder/raw/refs/heads/amd-mainline/releases/linux_glibc_2_28_x86_64/librocprof-trace-decoder.so
RUN wget -O /opt/rocm/lib/librocprof-trace-decoder.so https://github.com/ROCm/rocprof-trace-decoder/raw/refs/heads/amd-mainline/releases/linux_glibc_2_28_x86_64/librocprof-trace-decoder.so

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This downloads a shared library from a moving branch URL (raw/refs/heads/...). That makes builds non-reproducible and increases supply-chain risk. Prefer pinning to an immutable release asset or commit SHA, and verify integrity (e.g., checksum/signature) as part of the build.

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ldconfig is run before this library is added to /opt/rocm/lib. Since /opt/rocm/lib is intended to be resolved via the dynamic loader cache, add an ldconfig after downloading the .so (or otherwise ensure the runtime can locate it) to avoid runtime/linker failures.

Suggested change
RUN sudo wget -O /opt/rocm/lib/librocprof-trace-decoder.so https://github.com/ROCm/rocprof-trace-decoder/raw/refs/heads/amd-mainline/releases/linux_glibc_2_28_x86_64/librocprof-trace-decoder.so
RUN sudo wget -O /opt/rocm/lib/librocprof-trace-decoder.so https://github.com/ROCm/rocprof-trace-decoder/raw/refs/heads/amd-mainline/releases/linux_glibc_2_28_x86_64/librocprof-trace-decoder.so && \
ldconfig

Copilot uses AI. Check for mistakes.

# Workaround broken miopen cmake files
RUN sed -i 's,;/usr/lib/x86_64-linux-gnu/librt.so,,g' /opt/rocm/lib/cmake/miopen/miopen-targets.cmake

Expand Down
Loading