Rocm7.2.3 changes #4796
Merged
JeniferC99 merged 18 commits intorelease/rocm-rel-7.2from Apr 21, 2026
Merged
Conversation
Make the list a static const auto and remove the inserts that always happen during the matcher after copying the const to a local matcher and then performing the match on find_nop_reshapes() Cleaning this up should stop the overhead of added copy, inserts and destroying of local variables.
Refactor the output alias so we can support operators like make_tuple.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release/rocm-rel-7.2 #4796 +/- ##
========================================================
+ Coverage 92.21% 92.24% +0.03%
========================================================
Files 561 563 +2
Lines 27228 27760 +532
========================================================
+ Hits 25107 25605 +498
- Misses 2121 2155 +34
🚀 New features to boost your workflow:
|
Collaborator
Author
|
Last to go in would be - #4775 |
TedThemistokleous
force-pushed
the
rocm7.2.3_changes
branch
from
fdc3d3a to
df5ad7a
Compare
TedThemistokleous
changed the title
Collaborator
Author
|
Still need to get this in but the rest should be valid/working - #4775 |
causten
approved these changes
Apr 17, 2026
[AIGenerated] Add tests for external streams as well as fallback modes Fix format Cleanup Update context to not rebind on the same stream Remove noop clearStream call remove clear_stream from tests Update context and tests fix format
Collaborator
Author
|
Adding a Cherry-pick of a squash for #4775 into this to ensure there's no regression with the other changes. This is a performance fix - but if this becomes an issue can be removed with minimal risk. Its still in review but its changes are viable and have been used to get more stable numbers while leveraging a few caveats for a key customer workload. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Set of changes that are going into rocm7.2.3 for customer related fixes/issues
Technical Details
Running this to see how CI is overnight to ensure no surprises in the morning.
Changelog Category
Add a
CHANGELOG.mdentry for any option other thanNot Applicable