Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[AIMIGRAPHX-828] Cross Compile Pt 2: add env variable to enable cross compilation #4795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
[AIMIGRAPHX-828] Cross Compile Pt 2: add env variable to enable cross compilation #4795
Changes from all commits
43b24e4aedf850acf9c4606a966ceed1afc6bcfc01b95d1be424f5450bbd8899f53832d10cd5acbde4eb976f9e0c288251a56b2795384040e36c121File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think we should use env variable here. Instead the
targetorcontextshould tell us if we can run finalize.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think we should use env variable here. Instead the
targetorcontextshould tell us if we can run finalize.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this. Everything should just use the function that takes the
context. The other overloads should be removed, in a later PR.Check warning on line 84 in src/targets/gpu/eliminate_data_type_for_gpu.cpp
Check warning on line 92 in src/targets/gpu/eliminate_data_type_for_gpu.cpp
Check warning on line 104 in src/targets/gpu/eliminate_data_type_for_gpu.cpp
Check warning on line 112 in src/targets/gpu/eliminate_data_type_for_gpu.cpp
Check warning on line 141 in src/targets/gpu/eliminate_data_type_for_gpu.cpp
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.