Open
Conversation
This hacks in some unit tests that will narrow down what part of uECC failed, if the test fails.
maribu
requested review from
MichelRottleuthner,
aabadie and
leandrolanzieri
as code owners
crasbe
added
Type: enhancement
Member
Why would we not want this? |
Member
Author
|
It contains a nasty hack to access an internal function for unit testing. There are btw also tests upstream: https://github.com/kmackay/micro-ecc/blob/master/test/test_compress.c They won't catch any issues in our integration, though. We could try to PR changes to the upstream tests that would allow embedding them into an external application - such as a RIOT app - and then do that instead. |
Member
|
I mean IMO that looks fine to me. Clearly they left the access there for such cases, given that they also use it but I get your point |
Member
Author
|
One benefit of this is that a catastrophic bug that would cause an all zero shared key to be generated would be caught, but not by the "do both parties arrive at the same shared key" test that follows. |
AnnsAnns
requested changes
Dec 2, 2025
Member
AnnsAnns
left a comment
AnnsAnns
left a comment
There was a problem hiding this comment.
I'm in favour of adding this, I see nothing wrong with having a backup test for this. But I'm open to other opinions.
Also, a few long lines in there ;)
| }; | ||
| uint8_t alignas(uECC_word_t) result_got[sizeof(result_expected)]; | ||
| uECC_vli_modMult_fast((void *)result_got, (void *)input1, (void *)input2, curve); | ||
| return _test_compare("uECC_vli_modMult_fast()", result_got, result_expected, sizeof(result_expected)); |
| }; | ||
| uint8_t alignas(uECC_word_t) result_got[sizeof(result_expected)]; | ||
| uECC_vli_modSquare_fast((void *)result_got, (void *)input, curve); | ||
| return _test_compare("uECC_vli_modSquare_fast()", result_got, result_expected, sizeof(result_expected)); |
Comment on lines
+163
to
+164
| uECC_vli_mult((void *)result_got, (void *)input1, (void *)input2, sizeof(input1) / sizeof(uECC_word_t)); | ||
| return _test_compare("uECC_vli_mult()", result_got, result_expected, sizeof(result_expected)); |
Comment on lines
+189
to
+191
| uECC_word_t carry_got = uECC_vli_add((void *)result_got, (void *)input1, (void *)input2, sizeof(input1)/sizeof(uECC_word_t)); | ||
| return _test_compare("uECC_vli_add()", result_got, result_expected, sizeof(result_expected)) | ||
| && _test_compare("uECC_vli_add() carry", &carry_got, &carry_expected, sizeof(carry_expected)); |
| }; | ||
| const uECC_word_t borrow_expected = 1; | ||
| uint8_t alignas(uECC_word_t) result_got[sizeof(result_expected)]; | ||
| uECC_word_t borrow_got = uECC_vli_sub((void *)result_got, (void *)input1, (void *)input2, sizeof(input1)/sizeof(uECC_word_t)); |
Comment on lines
+248
to
+249
| uECC_vli_mmod((void *)result_got, (void *)product, (void *)mod, sizeof(mmod_result_expected) / sizeof(uECC_word_t)); | ||
| return _test_compare("uECC_vli_mmod()", result_got, mmod_result_expected, sizeof(mmod_result_expected)); |
| alignas(uECC_word_t) uint8_t product[sizeof(mmod_input)]; | ||
| memcpy(product, mmod_input, sizeof(product)); | ||
| curve->mmod_fast((void *)result_got, (void *)product); | ||
| return _test_compare("curve->mmod_fast()", result_got, mmod_result_expected, sizeof(mmod_result_expected)); |
crasbe
added
the
State: waiting for author
Contributor
|
@maribu ping 👀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This hacks in some unit tests that will narrow down what part of uECC failed, if the test fails.
Not sure if we actually want this. It has been useful to narrow down what was causing the AVR test to fail, though.
Testing procedure
The test should still pass, but provide a bit more output.
Issues/PRs references
This was helpful for #21920