Skip to content

feat: validate Terms used as parameter types are appropriate (into #2309) #2345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
acl-cqc wants to merge 34 commits into
base: main
Choose a base branch
from

Handle variables by is_cached_static

1bf35d8
Select commit
Loading
Failed to load commit list.
Open

feat: validate Terms used as parameter types are appropriate (into #2309) #2345

Handle variables by is_cached_static
1bf35d8
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 25, 2025 in 1s

82.14% (-0.02%) compared to cbaf9bf

View this Pull Request on Codecov

82.14% (-0.02%) compared to cbaf9bf

Details

Codecov Report

❌ Patch coverage is 80.50314% with 124 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.14%. Comparing base (cbaf9bf) to head (1bf35d8).
⚠️ Report is 179 commits behind head on main.

Files with missing lines Patch % Lines
hugr-core/src/types/type_param.rs 82.25% 41 Missing ⚠️
hugr-core/src/import.rs 51.11% 15 Missing and 7 partials ⚠️
hugr-core/src/export.rs 46.15% 20 Missing and 1 partial ⚠️
hugr-core/src/extension/resolution/types_mut.rs 26.31% 8 Missing and 6 partials ⚠️
hugr-core/src/extension/resolution/types.rs 55.00% 9 Missing ⚠️
hugr-core/src/types/serialize.rs 90.19% 4 Missing and 1 partial ⚠️
hugr-core/src/extension/op_def.rs 69.23% 0 Missing and 4 partials ⚠️
hugr-core/src/types/poly_func.rs 90.47% 0 Missing and 4 partials ⚠️
hugr-core/src/extension/resolution.rs 0.00% 1 Missing ⚠️
hugr-core/src/extension/type_def.rs 92.30% 1 Missing ⚠️
... and 2 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2345      +/-   ##
==========================================
- Coverage   82.15%   82.14%   -0.02%     
==========================================
  Files         241      241              
  Lines       44006    43949      -57     
  Branches    39846    39778      -68     
==========================================
- Hits        36154    36101      -53     
+ Misses       5859     5858       -1     
+ Partials     1993     1990       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov