Skip to content

Fix confusion between stdlib random and np.random #4645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abbycross merged 4 commits into from
Feb 9, 2026
Merged

Fix confusion between stdlib random and np.random #4645

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
656f41a
Fix confusion between stdlib random and np.random
jlapeyre Feb 9, 2026
b16abf5
fix lint
abbycross Feb 9, 2026
9130225
Update qiskit-implementation.ipynb
abbycross Feb 9, 2026
4c36a08
Update qiskit-implementation.ipynb
abbycross Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .../courses/basics-of-quantum-information/entanglement-in-action/qiskit-implementation.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
},
{
"cell_type": "code",
"execution_count": 2,
"execution_count": null,
"id": "1a60f419",
"metadata": {},
"outputs": [],
Expand All @@ -56,7 +56,7 @@
"from qiskit.visualization import plot_histogram, array_to_latex\n",
"from qiskit.result import marginal_distribution\n",
"from qiskit.circuit.library import UGate\n",
"from numpy import pi, random"
"from math import pi, random"
Copy link
Copy Markdown
Collaborator

@abbycross abbycross Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jlapeyre the json was invalid - this fix now passes the linter but pls let me know if it doesn't match what is needed here

Copy link
Copy Markdown
Collaborator

@abbycross abbycross Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've now put import random on its own line in the notebook (vs. directly in the json), and it healed the lint problem - that looks more like what you wanted to accomplish

Copy link
Copy Markdown
Collaborator Author

@jlapeyre jlapeyre Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abbycross Thankyou. This is correct. Next time, I'll run jq.

]
},
{
Expand Down
Loading