Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #805 +/- ##
==========================================
- Coverage 96.87% 96.80% -0.08%
==========================================
Files 113 112 -1
Lines 23062 23045 -17
==========================================
- Hits 22342 22309 -33
- Misses 720 736 +16 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
Motivation and context / Related issue
This PR removes the OpenMP-specific EMD implementation and the related build-time OpenMP detection. The threaded backend was not providing enough value to justify the extra solver path, build complexity, and platform-specific maintenance burden.
numThreadsis kept temporarily as a compatibility argument, but it now falls back to the single-threaded solver and emits a warning when set to a value greater than1.How has this been tested (if it applies)
.venv/bin/python -m pytest --durations=20 -v test/ --doctest-modules --ignore ot/gpu/2490 passed, 424 skipped, 6 xfailedPR checklist