Skip to content

[perf] Make projectile cleanup deterministic in OnSecondUpdate #3212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Xekep wants to merge 1 commit into
base: general-devel
Choose a base branch
from
Open

[perf] Make projectile cleanup deterministic in OnSecondUpdate #3212

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions TShockAPI/Bouncer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3056,20 +3056,17 @@ internal void OnQuickStack(object sender, OTAPI.Hooks.Chest.QuickStackEventArgs

internal void OnSecondUpdate()
{
Task.Run(() =>
var threshold = DateTime.UtcNow.AddSeconds(-5);
foreach (var player in TShock.Players)
{
foreach (var player in TShock.Players)
if (player != null && player.TPlayer.whoAmI >= 0)
{
if (player != null && player.TPlayer.whoAmI >= 0)
lock (player.RecentlyCreatedProjectiles)
{
var threshold = DateTime.Now.AddSeconds(-5);
lock (player.RecentlyCreatedProjectiles)
{
player.RecentlyCreatedProjectiles = player.RecentlyCreatedProjectiles.Where(s => s.CreatedAt > threshold).ToList();
}
player.RecentlyCreatedProjectiles.RemoveAll(s => s.CreatedAt <= threshold);
}
}
});
}
}

/// <summary>
Expand Down