Skip to content

Improve mobile inline search and remote options UX#77

Draft
tyreseluo wants to merge 2 commits intoProject-Robius-China:mainfrom
tyreseluo:codex/mobile-inline-search-remote-options
Draft

Improve mobile inline search and remote options UX#77
tyreseluo wants to merge 2 commits intoProject-Robius-China:mainfrom
tyreseluo:codex/mobile-inline-search-remote-options

Conversation

@tyreseluo
Copy link
Copy Markdown

Summary

  • switch mobile room search to an inline flow instead of relying on the desktop-style modal
  • add inline remote-search actions (Search People, Search Rooms, Search Spaces) for mobile
  • keep remote-search actions visible even when local matches exist (mobile + desktop)
  • fix the mobile remote-action buttons rendering as blank placeholders by forcing label sync on active adaptive instances
  • keep desktop behavior intact while explicitly syncing adaptive visibility for search entry icons
  • add/update the task spec for this work under specs/

Root Cause

The mobile remote-search option buttons were created, but in the AdaptiveView + CachedWidget path the label updates could miss the active instance, so the UI rendered button placeholders without text.

What Changed

  • src/home/rooms_sidebar.rs
    • added mobile inline remote-search panel state + actions
    • added remote result rendering and click handling
    • added robust adaptive sync for icon visibility and remote button labels
  • src/app.rs
    • show desktop remote-search action buttons even when local results exist
  • src/shared/room_filter_input_bar.rs
    • exposed a ref method to control search icon visibility at runtime
  • src/home/rooms_list_header.rs
    • exposed a ref method to control desktop search-entry button visibility at runtime
  • resources/i18n/en.json, resources/i18n/zh-CN.json
    • improved remote-search action button text with clearer descriptions
    • removed TODO wording from search text
  • src/home/search_messages.rs
    • removed literal Search (TODO) fallback text
  • specs/task-mobile-inline-search-with-remote-options.spec.md
    • added the implementation spec and acceptance scenarios

Validation

  • cargo build

@tyreseluo tyreseluo changed the title [codex] Improve mobile inline search and remote options UX Improve mobile inline search and remote options UX Apr 10, 2026
@tyreseluo tyreseluo marked this pull request as ready for review April 10, 2026 04:31
@tyreseluo tyreseluo marked this pull request as draft April 10, 2026 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant