Skip to content

feat: modifiable nominatim endpoint #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DennisOSRM merged 4 commits into from
May 3, 2026
+8 −3
Merged

feat: modifiable nominatim endpoint #385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
090e00c
Make nominatim endpoint modifiable
nhirokinet Aug 16, 2025
7b00a51
Potential fix for pull request finding
nhirokinet Apr 13, 2026
41327f8
Merge branch 'gh-pages' into gh-pages
DennisOSRM Apr 29, 2026
2f6a5b2
Merge branch 'gh-pages' into gh-pages
DennisOSRM May 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions scripts/replace.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ function applyReplacements(content, env) {
const BACKEND = env.OSRM_BACKEND || 'https://router.project-osrm.org'
const LANGUAGE = env.OSRM_LANGUAGE || 'en'
const DEFAULT_LAYER = env.OSRM_DEFAULT_LAYER || 'streets'
const NOMINATIM_ENDPOINT = env.NOMINATIM_ENDPOINT || 'https://nominatim.openstreetmap.org/'

Comment thread
DennisOSRM marked this conversation as resolved.
let options = content

Expand All @@ -34,6 +35,7 @@ function applyReplacements(content, env) {
// Leaflet uses LatLng
else options = options.replace('38.8995,-77.0269', latlng)
}
if (NOMINATIM_ENDPOINT) options = options.replace('https://nominatim.openstreetmap.org/', NOMINATIM_ENDPOINT)
Copy link
Copy Markdown
Contributor Author

@nhirokinet nhirokinet Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

options is not provided option but managed in this repository, so I think it is not needed to accept the one without trailing slash(/).


return options
}
Expand Down
4 changes: 2 additions & 2 deletions src/geocoder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@ function parseCoords(query) {
// For non-coordinate input, falls through to Nominatim forward-geocode as normal.
// Also bridges leaflet-control-geocoder's Promise API to the callback-based API
// that leaflet-routing-machine's autocomplete expects.
geocoder.coordPreserving = function() {
var nominatim = L.Control.Geocoder.nominatim();
geocoder.coordPreserving = function(nominatimUrl) {
var nominatim = L.Control.Geocoder.nominatim({serviceUrl: nominatimUrl});
Comment on lines +54 to +55
Copy link
Copy Markdown
Contributor Author

@nhirokinet nhirokinet Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nominatimUrl will never be undefined or empty as there is default value. Do we need it?

Copy link
Copy Markdown
Contributor Author

@nhirokinet nhirokinet May 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nominatimUrl never gets null.

Copy link
Copy Markdown
Contributor Author

@nhirokinet nhirokinet May 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like other variables 'https://nominatim.openstreetmap.org/' is placed as default and code works as replacement.
And this is just passing to libraries and I think this normalization should be done in L.Control.Geocoder.nominatim, not here.


function withCallback(promise, cb, context) {
return promise.then(function(results) {
Expand Down
2 changes: 1 addition & 1 deletion src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ function makeIcon(i, n) {
}

var plan = new ReversablePlan([], {
geocoder: createGeocoder.coordPreserving(),
geocoder: createGeocoder.coordPreserving(leafletOptions.nominatim && leafletOptions.nominatim.path),
Copy link
Copy Markdown
Contributor Author

@nhirokinet nhirokinet May 3, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is changed following AI code comment. Both are fine for me and just which is preferred by code owners.
#385 (comment)

language: mergedOptions.language,
routeWhileDragging: true,
createMarker: function(i, wp, n) {
Expand Down
3 changes: 3 additions & 0 deletions src/leaflet_options.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,6 +292,9 @@ var leafletOptions = {
three: satellite,
four: osm,
five: osm_de
},
nominatim: {
path: 'https://nominatim.openstreetmap.org/'
Copy link
Copy Markdown
Contributor Author

@nhirokinet nhirokinet May 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just like neighbor code is.

}
Comment on lines +295 to 298
Copy link
Copy Markdown
Contributor Author

@nhirokinet nhirokinet Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test/leaflet_options.test.js looks like not having this kind of test for other parameters

};

Expand Down
Loading