Supports diacritics in region navigation view names#3388
Merged
brianlagunas merged 1 commit intomasterfrom Mar 28, 2026
Merged
Conversation
Ensures that view names containing diacritics, such as umlauts, are correctly resolved by unescaping the URI path during region navigation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This change ensures that view names containing URI-escaped characters, such as diacritics (e.g., umlauts), are correctly unescaped when used in region navigation. The
RegionNavigationContentLoaderin both Maui and WPF now explicitly callsUri.UnescapeDataStringon the navigation contract, allowing views like "TestäöüView" to be properly resolved. New test cases have been added to validate this behavior.Additionally, the
PrismAppBuilder's initialization process has been streamlined. The internal_moduleCatalogActionslist and its correspondingAddModuleCatalogActionmethod have been removed. Module catalog configuration actions are now directly registered with the_initializationslist, consolidating the initialization phases and simplifying the builder's internal logic.Bugs Fixed
Behavioral Changes
Navigation to views with URI-escaped characters (e.g.,
MyView%C3%A4forMyViewä) will now correctly resolve, allowing applications to use view names with a wider range of characters without issue. Previously, such navigation attempts might have failed to find the target view.PR Checklist
UriParsingHelperFixture.cs)