Fix executionInformation in config export result#1441
Open
SteveL-MSFT wants to merge 2 commits intoPowerShell:mainfrom
Open
Fix executionInformation in config export result#1441SteveL-MSFT wants to merge 2 commits intoPowerShell:mainfrom
SteveL-MSFT wants to merge 2 commits intoPowerShell:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes missing/incorrect executionInformation in configuration export output so exported configs (and exported resources within them) include execution metadata in the expected camelCase shape.
Changes:
- Plumbs
ExecutionInformationinto the config export flow and attaches it to exported resources and the exported configuration document. - Updates serde casing behavior in config document types to ensure
executionInformation(and related fields) serialize as camelCase. - Adds a Pester test validating
executionInformationis present indsc config exportresults.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| lib/dsc-lib/src/configure/mod.rs | Passes/sets execution info during config export and per exported resource. |
| lib/dsc-lib/src/configure/config_doc.rs | Adjusts serde casing rules to camelCase for config doc structs (fixes executionInformation casing). |
| dsc/tests/dsc_config_export.tests.ps1 | Adds test coverage asserting execution information appears in config export output. |
| dsc/src/resource_command.rs | Updates resource export path to compile with new helper signature by passing ExecutionInformation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Noticed during my demo that
executionInformationwasn't being filled infor export.executionInformationto the export resultexecutionInformationto each resource within the exportexecutionInformationin a few places