Skip to content

Adding Azure blob support#96

Closed
ptasker wants to merge 5 commits intoPowerDNS:mainfrom
ptasker:main
Closed

Adding Azure blob support#96
ptasker wants to merge 5 commits intoPowerDNS:mainfrom
ptasker:main

Conversation

@ptasker
Copy link
Copy Markdown

@ptasker ptasker commented Nov 19, 2025

This pull request adds support for Azure Blob Storage as a backend for storing snapshots in Lightning Stream, alongside existing S3 and filesystem options. It includes documentation updates, configuration examples, and local testing support via Azurite in Docker Compose. The changes also update environment variable formatting for Docker services and clarify sweeper configuration.

cc @Luit @ahouene

@ptasker ptasker marked this pull request as ready for review March 5, 2026 16:34
@ptasker
Copy link
Copy Markdown
Author

ptasker commented Mar 5, 2026

Finally got around to fixing this up, ready for review!

@Luit Luit self-requested a review March 16, 2026 11:15
@Luit Luit self-assigned this Mar 16, 2026
@Luit
Copy link
Copy Markdown
Contributor

Luit commented Mar 16, 2026

One thing I'd like to know first is why this PR seems to revert commit 55587d1 and implement the Generation IDs suddenly? This does not seem necessary at all.

@ptasker
Copy link
Copy Markdown
Author

ptasker commented Mar 16, 2026

One thing I'd like to know first is why this PR seems to revert commit 55587d1 and implement the Generation IDs suddenly? This does not seem necessary at all.

We're using the Generation ID's pretty heavily as it allows for us to track propagation throughout the fleet of servers. It allows us to keep track of how long it takes for the snapshots to propagate.

@Luit
Copy link
Copy Markdown
Contributor

Luit commented Mar 23, 2026

I've discussed this internally and I'm not comfortable pulling this in its current state. The (re)introduction of GenerationID with a very different purpose than what it was originally used for, plus the numerous metrics changes are thing I'd rather not review for the purpose of including Azure support in Lightning Stream. I'll have to account for the interactions with our enterprise version as well, so a more limited PR with just the storage parts is more likely to get merged more quickly.

I'm happy to discuss any issues tracking snapshot propagation, or metrics you'd like to see added. You're more than welcome to open a few Discussions.

@ptasker ptasker mentioned this pull request Mar 24, 2026
4 tasks
@ptasker
Copy link
Copy Markdown
Author

ptasker commented Mar 24, 2026

Closing in favor of #121

@ptasker ptasker closed this Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants