Skip to content

Introduce instance ready hook#123

Open
Luit wants to merge 5 commits intomainfrom
introduce-instance-ready-hook
Open

Introduce instance ready hook#123
Luit wants to merge 5 commits intomainfrom
introduce-instance-ready-hook

Conversation

@Luit
Copy link
Copy Markdown
Contributor

@Luit Luit commented Apr 1, 2026

For the readiness tracking of Lightning Stream Enterprise we need a hook that checks snapshots (of any (Snapshot).Kind) to ensure health checks work properly and the "only_once" option waits until applying everything instead of only SnapshotKind.

@Luit Luit requested a review from neilcook April 1, 2026 13:42
@Luit Luit self-assigned this Apr 1, 2026
@Luit
Copy link
Copy Markdown
Contributor Author

Luit commented Apr 1, 2026

Note: the LoadOnce is now done before managing waitingForInstances because that seemed more logical to me. It wasn't necessary for the implementation because, as the comment on the new hook implies, the check should work independently of whether the update it's currently processing has been applied or not. If I hadn't reorganised this, the diff would only be 10-ish lines.

@nvaatstra nvaatstra self-requested a review April 2, 2026 07:54
@Luit Luit force-pushed the introduce-instance-ready-hook branch from 27ce19e to 7cb1280 Compare April 2, 2026 09:12
Copy link
Copy Markdown
Contributor

@nvaatstra nvaatstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; Looks like a sensible place to include this new hook

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants