Skip to content

fix: prevent session replay screenshot PII leak on PixelCopy timeout #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
marandaneto wants to merge 4 commits into
base: main
Choose a base branch
from
+214 −112
Draft

fix: prevent session replay screenshot PII leak on PixelCopy timeout #471

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c73a0c8
fix: prevent session replay screenshot PII leak on PixelCopy timeout
marandaneto Mar 30, 2026
2ef4bd3
fix: move mask rect collection to main thread and add fallback rects
marandaneto Mar 30, 2026
86a0a6f
fix: move isOnDrawnCalled reset to right before PixelCopy.request
marandaneto Mar 30, 2026
a9b9296
fix: remove isOnDrawnCalled checks from findMaskableWidgets
marandaneto Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/warm-pixels-glow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'posthog-android': patch
---

Fix session replay screenshot PII leak on PixelCopy timeout and improve masking loop early exit
10 changes: 5 additions & 5 deletions posthog-android/src/main/java/com/posthog/android/replay/PostHogReplayIntegration.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -982,13 +982,13 @@ public class PostHogReplayIntegration(
return@request
}

maskableWidgets.forEach {
for (rect in maskableWidgets) {
Copy link
Copy Markdown
Member Author

@marandaneto marandaneto Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a bug but wasting cycles

if (isOnDrawnCalled) {
config.logger.log("Session Replay screenshot discarded due to screen changes.")
success = false
return@forEach
break
}
canvas.drawRoundRect(RectF(it), 10f, 10f, paint)
canvas.drawRoundRect(RectF(rect), 10f, 10f, paint)
}
} else {
config.logger.log("Session Replay screenshot discarded due to screen changes.")
Expand Down Expand Up @@ -1021,9 +1021,9 @@ public class PostHogReplayIntegration(

try {
// await for 1s max
latch.await(1000, TimeUnit.MILLISECONDS)
val completed = latch.await(1000, TimeUnit.MILLISECONDS)
Copy link
Copy Markdown
Member Author

@marandaneto marandaneto Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the PixelCopy callback can take longer than the 1-second latch timeout

very unlikely but doing the change anyway


if (success) {
if (completed && success) {
base64 = bitmap.webpBase64()
}
} catch (e: Throwable) {
Expand Down
Loading