Update pistoncore-glutin_window in conrod_piston#1406
Open
adumbidiot wants to merge 2 commits intoPistonDevelopers:masterfrom
Open
Update pistoncore-glutin_window in conrod_piston#1406adumbidiot wants to merge 2 commits intoPistonDevelopers:masterfrom
pistoncore-glutin_window in conrod_piston#1406adumbidiot wants to merge 2 commits intoPistonDevelopers:masterfrom
Conversation
Collaborator
|
Hi, thanks for the PR. Unfortunately I am not able to verify that this is working. When I try to run the @bvssvni Ping, can you help with this? P.S. The failing checks are not caused by the changes in this PR, but is due to a breaking change in |
Member
|
@alvinhochun I've tested these changes and they work. |
Contributor
Author
|
I've been playing with this a bit more and I'm getting problems with logical vs physical pixels. I'll try to fix that when I get some time. |
Contributor
Author
|
@alvinhochun I think this works now if |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
piston2d-graphicsto0.39.xandpiston_windowto0.113.x, which bumpspistoncore-glutin_windowfrom0.66.0to0.67.2. I did this to fix PistonDevelopers/glutin_window#187 which occurs while trying to useconrod_piston.