feat: integrate updater installation into container update process

[aryaman-payram]

No description provided.

[coderabbitai]

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4264218b-82a2-4cb0-be85-b1aeb38b05b5

📥 Commits

Reviewing files that changed from the base of the PR and between 6c31d29 and ba7039b.

📒 Files selected for processing (1)

• setup_payram.sh

---

Summary by CodeRabbit

• Bug Fixes
  • Ensured the updater is (re)installed and activated even when keeping the same installed version so updates remain available and the service is maintained.
  • Improved macOS compatibility by disabling the background service on macOS hosts, preventing unwanted service activation while preserving behavior on other platforms.

Walkthrough

The install/update flow in setup_payram.sh was adjusted: when keeping the current container tag, the script now installs the payram updater after restarting the container; installer invocation now passes ENABLE_SERVICE based on OS (disabled on macOS).

Changes

Cohort / File(s)	Summary
Setup Script Updates setup_payram.sh	In update_payram_container(), invoke install_payram_updater after restarting the payram container when the selected tag equals the current tag. In install_payram_updater(), make ENABLE_SERVICE configurable via a local enable_svc variable (defaults to "true", set to "false" on macOS / Darwin) and pass it into the installer command.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• feat: update reset_payram_environment steps for updater removal process #34 — modifies updater lifecycle handling; related to installer/updater lifecycle changes here.

Suggested reviewers

• sam6230i
• iam-joey

Poem

🐰 I hopped through lines of bash and cheer,

Restarted containers, then brought up the updater near.
macOS gets gentle paws—no service to bind,
Other systems wake the service up just fine.
A little patch, a tidy hop, and all aligned. 🥕

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	No pull request description was provided by the author, making it impossible to assess whether the description relates to the changeset.	Add a pull request description explaining the motivation, changes, and impact of integrating the updater installation into the container update flow.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: integrating updater installation into the container update process, which is reflected in the addition of updater installation during container updates.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch hotfix/updaterInstallationOnUpdateFlow

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@setup_payram.sh`:
- Around line 3299-3302: The current logic sets enable_svc based only on the
OS_FAMILY variable which may be missing in legacy config.env, causing macOS to
be treated as non-mac and enabling the service; update the detection that sets
local enable_svc (and the subsequent conditional that uses
ENABLE_SERVICE="$enable_svc") to also detect macOS via a reliable system check
(e.g., uname -s or OSTYPE) so the branch becomes true for macOS even if
OS_FAMILY is unset—modify the lines that set and test enable_svc and the
conditional that invokes bash "$updater_tmp" (the block using FORCE_REINSTALL,
QUIET, ENABLE_SERVICE and INIT_FLAGS) to use the combined check (OS_FAMILY ==
"macos" OR system uname indicates Darwin) before setting enable_svc="false".

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c9af446e-a8ce-445e-8700-df5a9b3c8d80

📥 Commits

Reviewing files that changed from the base of the PR and between c475627 and 6c31d29.

📒 Files selected for processing (1)

• setup_payram.sh