Skip to content

fix some incorrect mappings#296

Draft
BasiqueEvangelist wants to merge 5 commits intoParchmentMC:versions/1.21.xfrom
BasiqueEvangelist:remove-bad-mappings
Draft

fix some incorrect mappings#296
BasiqueEvangelist wants to merge 5 commits intoParchmentMC:versions/1.21.xfrom
BasiqueEvangelist:remove-bad-mappings

Conversation

@BasiqueEvangelist
Copy link
Copy Markdown

@BasiqueEvangelist BasiqueEvangelist commented Aug 5, 2024

  • ServerPlayer#sendSystemMessage's bypassHiddenChat is renamed to overlay, since it also controls whether the message goes to the action bar
  • closeContainer and doCloseContainer's javadocs are changed to better reflect what they do
  • Container's invalid stillValid javadoc is removed and some other javadocs are changed to fit the methods more

@BasiqueEvangelist
fix docs of ServerPlayer's closeContainer and co
5e55125
@BasiqueEvangelist
rename bypassHiddenChat to overlay
324bc00 
This flag doesn't just bypass chat visibility, it also puts the message
in the action bar. overlay is what the field in
ClientboundSystemChatPacket is called, so that's what I use here.
@BasiqueEvangelist
fix bad Container mappings
fe47f15
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Aug 5, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@sciwhiz12 sciwhiz12 added bug An error, misspell, incorrect information, or other issue mappings Changes to the mapping data 1.21.x For Minecraft 1.21.x labels Aug 6, 2024
Matyrobbrt
Matyrobbrt requested changes Aug 7, 2024
View reviewed changes
data/net/minecraft/server/level/ServerPlayer.mapping
ARG 5 dz
METHOD closeContainer ()V
COMMENT Sets the current crafting inventory back to the 2x2 square.
COMMENT Closes the container the player currently has open.
Copy link
Copy Markdown
Member

@Matyrobbrt Matyrobbrt Aug 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as below

@BasiqueEvangelist @Matyrobbrt
Apply suggestions from code review
0253d0a 
Co-authored-by: Matyrobbrt <65940752+Matyrobbrt@users.noreply.github.com>
@sciwhiz12 sciwhiz12 requested a review from Matyrobbrt November 9, 2024 13:04
Lanse505
Lanse505 approved these changes Nov 10, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Lanse505 Lanse505 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sciwhiz12 sciwhiz12 added the needs rebase Needs to be rebased to resolve merge conflicts label Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lanse505 Lanse505 Lanse505 approved these changes

@Matyrobbrt Matyrobbrt Awaiting requested review from Matyrobbrt

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

1.21.x For Minecraft 1.21.x bug An error, misspell, incorrect information, or other issue mappings Changes to the mapping data needs rebase Needs to be rebased to resolve merge conflicts

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@BasiqueEvangelist @CLAassistant @Lanse505 @Matyrobbrt @sciwhiz12