Improve Parameter Metadata display in QGC#20125
Closed
junwoo091400 wants to merge 1 commit intoPX4:mainfrom
Closed
Improve Parameter Metadata display in QGC#20125junwoo091400 wants to merge 1 commit intoPX4:mainfrom
junwoo091400 wants to merge 1 commit intoPX4:mainfrom
Conversation
Member
|
Good intent, but I don't think it's worth changing the old parser as we move to yaml. There we already have better formatting options. |
Contributor
Author
Yep good point, the YAML options sounds way better! I will then continue in a better YAML PR.
|
Member
|
@coderkalyan almost finished all of the transition in #19489 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe problem solved by this pull request
Currently the Parameter metadata are badly formatted in QGC, which makes the QGC user experience unpleasant. The goal is to have a beautiful / clearly formatted description for parameters that is separated with new-line characters as documented in the source code itself.
The QGC Issue that describes related issues: mavlink/qgroundcontrol#10382
Describe your solution
Change the Parameter metadata parser script to parse the description part properly by not removing the newline characters, so that QGC would display exactly the same line endings.
For this, I am planning to incorporate parser as following: