setup scripts: install dmidecode before using it#15388
Merged
Conversation
On normal desktop distributions dmidecode is preinstalled and I was assuming it's part of the core tools. Thanks to a hint #15241 (comment) I found out it's not and am installing the package before using it.
julianoes
approved these changes
Jul 21, 2020
Contributor
julianoes
left a comment
julianoes
left a comment
There was a problem hiding this comment.
That's ok. I would have just only done the check if dmidecode is available but up to you.
Member
Author
|
@julianoes I thought about that but if we're already addressing the problem the case where you have a VM with graphics but no |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe problem solved by this pull request
On normal desktop distributions dmidecode is preinstalled and I was assuming it's part of the core tools. Thanks to a hint #15241 (comment) I found out it's not and am installing the package before using it.
Test data / coverage
I checked the package to be available and already installed on my systems on Manjaro and Ubuntu 20.04.