build tools: bring GNU Arm Embedded Toolchain Version 9 to CI and setup scripts#14691
build tools: bring GNU Arm Embedded Toolchain Version 9 to CI and setup scripts#14691
Conversation
|
@MaEtUgR seems like we are still having issues in the Nuttx side of things - have you been testing master lately with the new GCC9 toolchain? |
99c24bc to
64969bc
Compare
|
@dagar @davids5 we continue to run into some errors here, but this time I think these might be false positives regarding the usage of |
|
Note that I tried adding |
|
@TSC21 it may be a bug in the code. Have a look at it. |
I did and I didn't see anything that might lead to a bug. Further research lead me to think that this might be actually a problem in the compiler, given that several users reported the same. |
| // rotate sensor clip counts into vehicle body frame | ||
| const Vector3f clipping{_accel_corrections.getBoardRotation() * | ||
| Vector3f{(float)accel.clip_counter[0], (float)accel.clip_counter[1], (float)accel.clip_counter[2]}}; | ||
| Vector3f{(float)accel.clip_counter[0], (float)accel.clip_counter[1], (float)accel.clip_counter[2]}}; |
There was a problem hiding this comment.
I have this problem with make format too but if you try to change it CI will complain to change it back because it's using a different version of astyle. That's a good example for why keeping the versions in sync like propsed in PX4/PX4-containers#267 makes sense.
|
This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions. |
|
Already solved. Closing |
Describe problem solved by this pull request
Following the validation of the binaries built with GNU Arm Embedded Toolchain Version 9-2019-q4-major in #14580, I am bringing the new version to both CI and setup scripts.
Describe your solution
px4-dev-nuttx-bionicandpx4-dev-nuttx-focal;