feat: add 'date.now' function for current timestamp support#5721
Open
sunyeongchoi wants to merge 9 commits intoPRQL:mainfrom
Open
feat: add 'date.now' function for current timestamp support#5721sunyeongchoi wants to merge 9 commits intoPRQL:mainfrom
sunyeongchoi wants to merge 9 commits intoPRQL:mainfrom
Conversation
Contributor
Author
|
I’ve enabled support for this syntax: |
Member
|
yes, |
8fb4c95 to
8aa97f2
Compare
max-sixty
reviewed
Mar 24, 2026
| @@ -1,7 +1,5 @@ | |||
| # Date functions | |||
|
|
|||
| These are all the functions defined in the `date` module: | |||
Member
There was a problem hiding this comment.
can we restore this? or was there a reason to remove?
Contributor
Author
There was a problem hiding this comment.
Oh It's my mistake. I'll restore this. Thank you.
max-sixty
reviewed
Mar 24, 2026
| gross_salary = (salary + payroll_tax | as int), | ||
| gross_salary_rounded = (gross_salary | math.round 0), | ||
| time = s"NOW()", # an s-string, given no `now` function exists in PRQL | ||
| time = date.now, # current timestamp; or use s"NOW()" for a dialect-specific s-string |
for more information, see https://pre-commit.ci
9d5f402 to
24bfc79
Compare
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5720
Add
date.nowfunction for current timestampAdds a
date.nowfunction to the PRQL standard library that returns the current timestamp, enabling time-based filtering and comparisons.