Refactor shadow style handling in HTML writer#887
Open
phili67 wants to merge 1 commit intoPHPOffice:masterfrom
Open
Refactor shadow style handling in HTML writer#887phili67 wants to merge 1 commit intoPHPOffice:masterfrom
phili67 wants to merge 1 commit intoPHPOffice:masterfrom
Conversation
Progi1984
reviewed
Feb 13, 2026
Member
Progi1984
left a comment
Progi1984
left a comment
There was a problem hiding this comment.
Hi,
Could you add an unit test?
Thanks
| protected function getStyleShadow(Shadow $style): array | ||
| { | ||
| if (!$style->isVisible()) { | ||
| if (is_null($style) or !is_null($style) and !$style->isVisible()) { |
Member
There was a problem hiding this comment.
Suggested change
| if (is_null($style) or !is_null($style) and !$style->isVisible()) { | |
| if (!$style->isVisible()) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There is a bug in the case the is_null($style) and !is_null($shape->getShadow()) too
Fixes # (issue)
Checklist: