Cleanup#306
Merged
Merged
Conversation
…onic/photonic out of scope
Wraps existing DagFaultAnalyzer + DemSamplerBuilder + DemSampler pipeline behind a single builder-style type. Lives in pecos-qec alongside the DEM machinery it wraps (input/output shape is QEC-specific: detectors and observables, not generic quantum state). Parity test confirms identical shot batches vs the raw pipeline given equal seeds.
MemStabSim wraps MemBuilder + MeasurementNoiseModel for raw-measurement sampling, parallel to DemStabSim which wraps DemSampler for detector-level sampling. Same builder pattern; different aggregation level. MemStabSim is the honest shape for engine integration (classical engine wants raw measurement outcomes). DemStabSim stays as the batch research API for detector events.
- Rename user-facing entry: sample_stab() -> pecos.sampling.stab(). - Document X4 (top-level sim()/sim_neo() + sampling.* catalog) with rejected alternatives X1-X3 spelled out. - Catalog as aliases-not-rivals: sampling.monte_carlo ~ sim, sampling.neo ~ sim_neo, sampling.stab new. - Establish graduation rule: submodule entry -> top-level shortcut only when load-bearing. - Reject 'orchestrator as top-level concept' with reasoning. - Pick .sampling(...) over .orchestration(...) as builder verb: sampling strategy varies, orchestrator is singular. - Mark Path A (QuantumEngine record-and-replay) superseded in skeleton doc.
… integration test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.