-
Notifications
You must be signed in to change notification settings - Fork 13
Add admin_level to divisions #419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
ee8e0df
add admin_level to divisions schema
stepps00 f6e0d23
add counterexample, update country yaml to support admin_level addition
stepps00 e39978f
update ext_expected_errors to match the actual validator message
stepps00 420480a
set admin_level to 1 for dependency
stepps00 9102cc0
define admin_level in defs.yaml, add to required list
stepps00 3899570
Merge branch 'dev' into admin_level
stepps00 7742dde
remove admin_level as required
stepps00 2812b60
update pydantic models with admin_level field
stepps00 031105f
add admin_level to each baseline json
stepps00 d087a62
make admin_level required for county and above, update schema and exa…
stepps00 8455162
regenerate baseline schema files
stepps00 64e4dfe
use uint8 AdminLevel for divisions admin_level, regenerate schema files
stepps00 eaeb185
centralize AdminLevel type with description, regenerate schema files
stepps00 2f2a300
ruff formatting
stepps00 488262c
fix make check error
stepps00 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| --- | ||
| id: counterexample:division:bad-admin-level | ||
| type: Feature | ||
| geometry: | ||
| type: Point | ||
| coordinates: [0, 0] | ||
| properties: | ||
| theme: divisions | ||
| type: division | ||
| version: 0 | ||
| subtype: country | ||
| names: | ||
| primary: Invalid admin_level Example | ||
| country: ZZ | ||
| hierarchies: | ||
| - - division_id: counterexample:division:bad-admin-level | ||
| subtype: country | ||
| name: Invalid admin_level Example | ||
| admin_level: -1 | ||
| ext_expected_errors: | ||
| - "minimum: got -1, want 0" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.