fix: decode BalancesSnapped event via strategy interface in snapBalances task#2881
Open
sparrowDom wants to merge 1 commit intomasterfrom
Open
fix: decode BalancesSnapped event via strategy interface in snapBalances task#2881sparrowDom wants to merge 1 commit intomasterfrom
sparrowDom wants to merge 1 commit intomasterfrom
Conversation
…ces task When snapBalances runs with --consol, the tx is sent to ConsolidationController but the BalancesSnapped event is emitted by the target strategy. The receipt's decoded events are bound to the controller's ABI so the event lookup failed and the task threw even though the tx succeeded. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
sparrowDom
requested review from
clement-ux,
naddison36 and
shahthepro
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2881 +/- ##
==========================================
- Coverage 49.32% 49.08% -0.25%
==========================================
Files 113 113
Lines 4916 4916
Branches 1362 1362
==========================================
- Hits 2425 2413 -12
- Misses 2487 2499 +12
Partials 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
snapBalanceshardhat task runs with--consol true, the tx is routed throughConsolidationController, but theBalancesSnappedevent is emitted by the targetCompoundingStakingSSVStrategy. Ethers only decodesreceipt.events[*].eventagainst the ABI of the contract used to send the tx, so the event lookup failed and the task threw even though the on-chain call succeeded.