virtio: Features change to 64 bit in all virtio_dispatch#616
virtio: Features change to 64 bit in all virtio_dispatch#616wyr-7 wants to merge 1 commit intoOpenAMP:mainfrom
Conversation
change all 32 bit features to 64 bit for adapt more features Signed-off-by: Yongrong Wang <wangyongrong@xiaomi.com>
arnopo
left a comment
There was a problem hiding this comment.
regarding virtio spec 64 bits could be not enough. If we update this I would be in favour of having a "features word selection index" as done in virtio mmio transport would be more reliable.
This imply to create new APIs and deprecate exiting ones...
For instance
static inline uint32_t
rpmsg_virtio_get_features_by_idx(struct rpmsg_virtio_device *rvdev, unint32 word_idx)
|
@arnopo Hi, from the virtio spec v1.3, the 64 bits is enough for now and linux use |
|
I don't know if Linux plans to do it. What I can see is that the virtio spec defines the feature bits in this way:
The virtio MMIO transport layer also supports an infinite number of feature bits So as this PR update the API i would prefer to directly address it instead of implementing an intermediate step that update the API I don't know if Linux plan to do it, what I can see is that it is that the virtio spec define the feature bits in this way:
The virtio MMIO transport layer also supports an infinite number of feature bits. So, as this PR updates the API, I would prefer to directly address it instead of implementing an intermediate step that also need an update of the API. |
|
@arnopo Thanks, as you said, it would be better to use "features word selection index" method to support feature bits larger than 64 bits and we will update this PR. |
|
This pull request has been marked as a stale pull request because it has been open (more than) 45 days with no activity. |
change all 32 bit features to 64 bit for adapt more features