Merged
Conversation
The rvdev->notify_wait_cb is not initialized to NULL if not set by the user. Initialize it to NULL and provide an API for the application to set it. Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
xiaoxiang781216
approved these changes
Apr 6, 2024
Collaborator
Author
|
@xiaoxiang781216 : could I consider that if it is ok for you it is also ok for @wyr8899 ? The initial PR was related to NuttX, right? |
Collaborator
CV-Bowen
approved these changes
Apr 18, 2024
wyr-7
approved these changes
Apr 18, 2024
Contributor
|
@arnopo @xiaoxiang781216 Sorry, I changed my account for some reasons and it is now approved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request is a fix of the PR #549
The rvdev->notify_wait_cb is never initialized to NULL if not set by the user.
the proposal to fix is to initialize it to NULL and provide an API for the user to set it.
The issue is reproduced using flood-ping test in linux environment.
@wyr8899 , pleas could you review it and give a feedback