[16.0][ADD] shopfloor_priting_base/mobile by rousseldenis · Pull Request #1085 · OCA/wms

rousseldenis · 2025-07-17T08:41:45Z

These modules allow to build base bricks to support printing

simahawk · 2025-07-17T10:24:37Z

shopfloor_mobile_printing_base/static/src/i18n/i18n.de.js

@@ -0,0 +1,113 @@
+/**
+ * Copyright 2020 Camptocamp SA (http://www.camptocamp.com)


leftover :)

simahawk · 2025-07-17T10:27:52Z

shopfloor_mobile_printing_base/static/src/components/printing-widget.js

+ * License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html).
+ */
+
+export var LabelPrinterWidget = Vue.component("label-printer", {


why not improving the input-number-spinner widget?

I hesitated

simahawk · 2025-07-17T10:30:55Z

shopfloor_printing_base/components/base.py

+
+    _inherit = "base.shopfloor.service"
+
+    def _printing_for(self, usage):


I don't understand what is it used for

This is needed to get the printing component on flows ones (reception, ...). This allows to reuse a certain logic and also to get specific ones when needed

simahawk · 2025-07-17T10:34:32Z

shopfloor_printing_base/components/printing.py

+        """
+        Returns the report to print
+        """
+        return self.work.menu.label_print_report_id


IMO instead of relying on a fixed report per menu item, we should pass this id into the menu data for the frontend and then the frontend will pas the id of the report to print. This way, the endpoint will work with any report.
Then I don't think we need this endpoint at all since we could use the standard endpoint for printing reports or a similar one.
Just ensure that you can pass the config to the menu or to the scenario.

Could you elaborate ? What do you mean by into the menu data ?

I mean: add a field to the menu item and include this info (id + name of report) in the menu item info that is sent to the app.

github-actions · 2025-11-16T12:14:34Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

…ng printing + add tests

…omponent

…nting component

…component should be visible

…red in session at refresh. In previous implementation, the variable was only given in API response but not stored inside session storage. As a refresh does not query odoo again but looks for variables inside session, the value was lost at refresh (and replaced with default false value).

…lobal next state fields

As soon as work context is not loaded yet at service init(), change them to properties to allow dynamic evaluation.

nicolas-delbovier-acsone · 2026-01-19T10:44:38Z

shopfloor_printing_base/services/service.py

+        self, base_response=None, data=None, next_state=None, message=None, popup=None
+    ):
+        data = data or {}
+        data["allow_print_label"] = self._menu.display_print_label_button


This implementation depends on PR #1115. That PR fixes the component initialization logic, ensuring self._menu is correctly populated. Without that fix, self._menu remains empty, preventing from accessing the necessary menu context.

- Remove duplicate BaseShopfloorService definition in components/base.py. - Keep the implementation in services/service.py to align with the base.shopfloor.service architecture. - Fixes Pylint R8180 (consider-merging-classes-inherited) where multiple classes were inheriting from the same parent in one module.

…sponse if the option is activated. When the option is not activated, we should not add the key with a false value in the response because changing the schema in that manner breaks unit tests expected outputs.

nicolas-delbovier-acsone · 2026-01-20T15:16:05Z

Improved the UI of the label-printer component. The updated layout provides a more robust and accessible experience on small warehouse scanner screens where space is limited.

nicolas-delbovier-acsone · 2026-01-20T15:21:21Z

The recent refactoring I made on this PR is to fix allow_print_label injection to ensure persistent state handling in the frontend.

The Issue: Previously, the allow_print_label flag was injected into the root of the response dictionary rather than inside the specific state data defined in _states(). Because the Shopfloor Vue application dynamically updates its local store based on the next_state payload, any data sent outside of that specific state key was ignored by the frontend’s persistence logic. This caused the flag to be lost upon browser refresh.

simahawk · 2026-01-20T16:06:39Z

shopfloor_base/services/service.py


-    def __init__(self, work_context):
-        super().__init__(work_context)
+    @property


why changing this to properties?

This change is from https://github.com/OCA/wms/pull/1115/changes which I needed as explained above

simahawk · 2026-02-06T15:44:08Z

shopfloor_base/services/validator.py

-
-        With the schema of the data send to the client to transition
+    def _states(self) -> dict:
+        """Returns a dict mapping next states with the schema


is this change needed?

I found the previous docstring to be confusing. The return value is not a "list of possible next states", it is a dict mapping next state to its data schema

simahawk · 2026-02-06T15:44:30Z

shopfloor_base/services/validator.py

        return self._actions_for("schema_detail")

+    def _get_global_fields_schemas(self) -> dict:
+        "Returns schemas of fields to be added in all next states data schemas"


triple quotes needed

simahawk · 2026-02-06T15:49:28Z

shopfloor_printing_base/components/printing.py

+
+    _name = "shopfloor.printing.action"
+    _inherit = "shopfloor.process.action"
+    _collection = "shopfloor.printing"


do we need another collection?

What collection would you want? "shopfloor.printing.base"? What value would a new collection bring?

simahawk · 2026-02-06T15:50:45Z

shopfloor_printing_base/tests/test_printing.py

+        super().tearDownClass()
+
+    @contextmanager
+    def _work_on_actions(self, **params):


there's already a work_on_actions in the base module, do we need this?

rousseldenis added the needs review label Jul 17, 2025

rousseldenis added this to the 16.0 milestone Jul 17, 2025

rousseldenis force-pushed the 16.0-add-shopfloor_mobile_printing_base-dro branch from 7b2ac59 to 1c01ec6 Compare July 17, 2025 08:44

rousseldenis added 2 commits July 17, 2025 11:02

[ADD] shopfloor_printing_base

00ffe6b

[ADD] shopfloor_mobile_printing_base

dbb532e

rousseldenis force-pushed the 16.0-add-shopfloor_mobile_printing_base-dro branch from 1c01ec6 to dbb532e Compare July 17, 2025 09:02

simahawk requested changes Jul 17, 2025

View reviewed changes

[IMP] shopfloor_printing_base: Add messages for printing

58d2551

rousseldenis mentioned this pull request Jul 17, 2025

[16.0][ADD] shopfloor_reception_print_label/mobile #1086

Open

jbaudoux mentioned this pull request Jul 18, 2025

Shopfloor reception - missing features #1018

Open

27 tasks

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 16, 2025

nicolas-delbovier-acsone mentioned this pull request Nov 20, 2025

[16.0][ADD] shopfloor_location_content_transfer_label/mobile #1114

Open

github-actions bot closed this Dec 21, 2025

rousseldenis reopened this Dec 22, 2025

github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 28, 2025

[IMP] shopfloor_printing_base: Manage different messages when launchi…

62ffbc6

…ng printing + add tests

rousseldenis force-pushed the 16.0-add-shopfloor_mobile_printing_base-dro branch from 4ad801e to 62ffbc6 Compare January 6, 2026 08:29

rousseldenis and others added 7 commits January 7, 2026 20:09

[IMP] shopfloor_printing_base: Allow to display or not the printing c…

1fe092d

…omponent

[IMP] shopfloor_mobile_printing_base: Allow to display or not the pri…

4840d57

…nting component

[IMP] shopfloor_mobile_printing_base: Add a method to check if print …

750c73f

…component should be visible

[REF] shopfloor_base: allow to pass variables to all next states

75cf350

[REF] shopfloor_printing_base: pass "allow_print_label" variable to g…

adc8090

…lobal next state fields

[FIX] shopfloor_base: Set _menu and _profile as properties

19ebe87

As soon as work context is not loaded yet at service init(), change them to properties to allow dynamic evaluation.

nicolas-delbovier-acsone reviewed Jan 19, 2026

View reviewed changes

nicolas-delbovier-acsone added 4 commits January 19, 2026 13:59

[FIX] shopfloor_printing_base: update unit test expected response

2c9c755

[FIX] shopfloor_printing_base: only add "allow_print_label" key in re…

ef5a4de

…sponse if the option is activated. When the option is not activated, we should not add the key with a false value in the response because changing the schema in that manner breaks unit tests expected outputs.

[IMP] shopfloor_mobile_printing_base: improve label-printer layout

f3ba312

[FIX] missing dependency

306d1d8

nicolas-delbovier-acsone mentioned this pull request Jan 28, 2026

[FIX] shopfloor_base: Set _menu and _profile as properties #1115

Open

sbejaoui approved these changes Jan 29, 2026

View reviewed changes

simahawk reviewed Feb 6, 2026

View reviewed changes

nicolas-delbovier-acsone added 2 commits February 9, 2026 08:16

[FIX] shopfloor_mobile_printing_ase: fix licenses

e9b128f

[FIX] shopfloor_base: fix docstring not triple quoted

edaadbc

		@@ -0,0 +1,113 @@
		/**
		* Copyright 2020 Camptocamp SA (http://www.camptocamp.com)


		_inherit = "base.shopfloor.service"

		def _printing_for(self, usage):

Uh oh!

Conversation

rousseldenis commented Jul 17, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 16, 2025

Uh oh!

nicolas-delbovier-acsone Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nicolas-delbovier-acsone commented Jan 20, 2026

Uh oh!

nicolas-delbovier-acsone commented Jan 20, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nicolas-delbovier-acsone Jan 19, 2026 •

edited

Loading