Skip to content

[18.0] shopfloor_mobile: migrate to v18#9

Merged
OCA-git-bot merged 4 commits intoOCA:18.0from
camptocamp:18-sf-mobile
Aug 6, 2025
Merged

[18.0] shopfloor_mobile: migrate to v18#9
OCA-git-bot merged 4 commits intoOCA:18.0from
camptocamp:18-sf-mobile

Conversation

@simahawk
Copy link
Contributor

@simahawk simahawk commented Jul 29, 2025

@mmequignon
Copy link
Member

ci is red
no git history

@simahawk
Copy link
Contributor Author

/ocabot migration shopfloor_mobile

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Jul 31, 2025
@OCA-git-bot
Copy link
Contributor

There's no issue in this repo with the title 'Migration to version 18.0' and the milestone 18.0, so not possible to add the comment.

@simahawk simahawk mentioned this pull request Jul 31, 2025
16 tasks
@simahawk simahawk marked this pull request as ready for review August 1, 2025 10:16
id = id.startsWith("uom-") ? id : parseInt(id, 10);
return _.find(this.sorted_packaging, ["id", id]);
const _id = id.startsWith("uom-") ? id : parseInt(id, 10);
return _.find(this.sorted_packaging, ["id", _id]);
Copy link

@ivantodorovich ivantodorovich Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

underscore (_) has been slowly being removed from Odoo. In 18.0, there are very few cases still using it. At some point in a future version it won't be available anymore.

It's recommended to migrate to the vanilla js alternatives

Copy link
Contributor Author

@simahawk simahawk Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not underscore, is lodash, and we have a frozen version here ;)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, alright then 😅

@simahawk
Copy link
Contributor Author

simahawk commented Aug 6, 2025

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-9-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c95dede into OCA:18.0 Aug 6, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 812e300. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants