[18.0][IMP] auth_oidc_environment: extra fields#922
[18.0][IMP] auth_oidc_environment: extra fields#922
Conversation
sbidoul
left a comment
There was a problem hiding this comment.
Does this need a migration or will it preserve existing values when this is deployed without setting the new env options?
AFAIK no migration script is needed, this does nothing while no env var is set. |
|
I had the impression that server_environment removes the colums from the database and gets the data from a json field, but I don't know how it works when you add already-used fields to the server env mixin. |
|
I'll try to have a look but if this is the case we might have problems here as well: OCA/server-env@3574e86 |
|
Good catch, the previous values are indeed ignored. I have opened this PR: OCA/server-env#264 |
1ae5441 to
0f8a6e6
Compare
| "depends": [ | ||
| "auth_oidc", | ||
| "server_environment", | ||
| "server_environment>18.0.1.0.6", |
There was a problem hiding this comment.
@sbidoul pre-commit doesn't like that. What would be the right syntax ?
There was a problem hiding this comment.
Ah yes, Odoo would not support that either.
So the trick is to do that with a new section in pyproject.toml:
[tool.whool]
depends_override = { "server_environment": "odoo-addon-server_environment ==18.0.*, >18.0.1.0.6" }
Needs OCA/server-env#264
I believe more fields make sense to be configurable by environment.
Typically when you use different SSO for test and production.