Conversation
8e4c614 to
d1f9533
Compare
d1f9533 to
4a9a88b
Compare
|
Does it mean we cannot edit currency rate on PO, so what the purpose of this module? |
|
@TheerayutEncoder The This module simply exposes that field and allows users to edit it when using |
Oh, I see it, so I think the way you did it is good. 👍 |
HviorForgeFlow
left a comment
There was a problem hiding this comment.
I think you've done a great job simplifying those legacy custom fields, would it be required a migration script to don't break existing instances using this module, at least historical data?
4a9a88b to
637a18a
Compare
|
@HviorForgeFlow Thank you for your advice. I added migration script and change version to 18.0.2.0.0 (purchase_manual_currency) and 18.0.1.0.1 (purchase_stock_manual_currency) |
637a18a to
2f46101
Compare
Refactor code manual_currency
is_manual,currency_diffbecause they are not usedtotal_company_currencysince the standard fieldamount_total_ccalready existsmanual_currency_ratewith the standardcurrency_rateThis PR is an improvement based on #2839
cc @TheerayutEncoder @AndreuOForgeFlow @HviorForgeFlow What do you think about this refactor?