Skip to content

[16.0][FIX] helpdesk_mgmt: Update contributor company to Escodoo#958

Open
marcelsavegnago wants to merge 1 commit intoOCA:16.0from
Escodoo:main-fix-contributor-company
Open

[16.0][FIX] helpdesk_mgmt: Update contributor company to Escodoo#958
marcelsavegnago wants to merge 1 commit intoOCA:16.0from
Escodoo:main-fix-contributor-company

Conversation

@marcelsavegnago
Copy link
Copy Markdown
Member

Replace ID42 Sistemas with Escodoo in README and CONTRIBUTORS

- Replace ID42 Sistemas with Escodoo in README and CONTRIBUTORS
- Remove OCA readme banner and fix licence badge typo
- Regenerate static description index.html
@marcelsavegnago marcelsavegnago changed the title [FIX] helpdesk_mgmt: Update contributor company to Escodoo [16.0][FIX] helpdesk_mgmt: Update contributor company to Escodoo Mar 9, 2026
Copy link
Copy Markdown
Contributor

@luisDIXMIT luisDIXMIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-commit in branch 16 is failing due to this issue OCA/oca-addons-repo-template#334

I faced it before and solved it by changing the pre-commit version like in this PR https://github.com/OCA/partner-contact/pull/2297/changes

Copy link
Copy Markdown

@marcos-mendez marcos-mendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated Review -- Tests Failed

1. Root cause of the test failure

The test failure is caused by a database connection error (Connection to the database failed) during the Odoo server startup, which is unrelated to the changes in this PR. This suggests a transient or environment-specific issue rather than a code bug introduced by the PR.


2. Suggested fix

There is no actionable code fix needed for the test failure, as it's a runtime environment issue. However, if this were a recurring issue, ensure that:

  • The database service (postgres.runboat-infra.svc.cluster.local) is reachable.
  • The odoo.conf file or environment variables are correctly configured for database access.
  • The runboat CI environment is properly initialized.

No code changes in the PR itself are causing this.


3. Additional code issues

There are no real bugs in the provided diffs. The changes are:

  • Minor documentation and README updates (license badge, contributor list, HTML structure)
  • No functional code changes

All changes are consistent with OCA patterns and style.


4. Test improvements

While the PR doesn't introduce functional code, the changes affect documentation and HTML rendering. To improve test coverage:

  • Add a test case to verify that the HTML description (index.html) is correctly generated and rendered without structural errors.
  • Use TransactionCase or SavepointCase to ensure the module's readme.rst and index.html are correctly generated using oca-gen-addon-readme.
  • Test contributor list rendering in CONTRIBUTORS.rst to ensure no regressions in HTML rendering or link formatting.

Example test snippet (to be added in tests/):

def test_readme_generation(self):
    # Ensure that the generated HTML description is valid and contains expected elements
    self.assertIn("Helpdesk Management", self.env['ir.module.module'].search([('name', '=', 'helpdesk_mgmt')]).description_html)

This would help catch regressions in documentation rendering or HTML structure changes.


Summary: No functional bugs. The test failure is environment-related. Documentation updates are valid and safe.


Reciprocal Review Request

Hi everyone! I found some test failures on this PR and left detailed feedback above. I am happy to discuss or help debug. In the meantime, if any of you get a chance, I would appreciate a look at my open PR(s):

My open PRs across OCA:

Reviewing each other's work helps the whole community move forward. Thank you!


Environment via OCA Neural Reviewer: Minikube + K8s Job + oca-ci/py3.10-odoo16.0 | Odoo 16.0
Automated review by OCA Neural Reviewer + qwen3-coder:30b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants