[16.0][FIX] helpdesk_mgmt: Update contributor company to Escodoo#958
[16.0][FIX] helpdesk_mgmt: Update contributor company to Escodoo#958marcelsavegnago wants to merge 1 commit intoOCA:16.0from
Conversation
- Replace ID42 Sistemas with Escodoo in README and CONTRIBUTORS - Remove OCA readme banner and fix licence badge typo - Regenerate static description index.html
luisDIXMIT
left a comment
There was a problem hiding this comment.
Pre-commit in branch 16 is failing due to this issue OCA/oca-addons-repo-template#334
I faced it before and solved it by changing the pre-commit version like in this PR https://github.com/OCA/partner-contact/pull/2297/changes
marcos-mendez
left a comment
There was a problem hiding this comment.
Automated Review -- Tests Failed
1. Root cause of the test failure
The test failure is caused by a database connection error (Connection to the database failed) during the Odoo server startup, which is unrelated to the changes in this PR. This suggests a transient or environment-specific issue rather than a code bug introduced by the PR.
2. Suggested fix
There is no actionable code fix needed for the test failure, as it's a runtime environment issue. However, if this were a recurring issue, ensure that:
- The database service (
postgres.runboat-infra.svc.cluster.local) is reachable. - The
odoo.conffile or environment variables are correctly configured for database access. - The
runboatCI environment is properly initialized.
No code changes in the PR itself are causing this.
3. Additional code issues
There are no real bugs in the provided diffs. The changes are:
- Minor documentation and README updates (license badge, contributor list, HTML structure)
- No functional code changes
All changes are consistent with OCA patterns and style.
4. Test improvements
While the PR doesn't introduce functional code, the changes affect documentation and HTML rendering. To improve test coverage:
- Add a test case to verify that the HTML description (
index.html) is correctly generated and rendered without structural errors. - Use
TransactionCaseorSavepointCaseto ensure the module'sreadme.rstandindex.htmlare correctly generated usingoca-gen-addon-readme. - Test contributor list rendering in
CONTRIBUTORS.rstto ensure no regressions in HTML rendering or link formatting.
Example test snippet (to be added in tests/):
def test_readme_generation(self):
# Ensure that the generated HTML description is valid and contains expected elements
self.assertIn("Helpdesk Management", self.env['ir.module.module'].search([('name', '=', 'helpdesk_mgmt')]).description_html)This would help catch regressions in documentation rendering or HTML structure changes.
✅ Summary: No functional bugs. The test failure is environment-related. Documentation updates are valid and safe.
Reciprocal Review Request
Hi everyone! I found some test failures on this PR and left detailed feedback above. I am happy to discuss or help debug. In the meantime, if any of you get a chance, I would appreciate a look at my open PR(s):
My open PRs across OCA:
- server-tools#3554 [MIG] datetime_formatter: Migration to 18.0
- server-tools#3548 [18.0][MIG] base_kanban_stage: Migration to 18.0
- hr-attendance#262 [16.0][ADD] Hr_attendance_idsecure: iDSecure (ControliD) attendance integration
- stock-logistics-workflow#2276 [16.0][ADD] stock_move_line_devaluation
- stock-logistics-workflow#2275 [16.0][ADD] Stock move line analytic account
- stock-logistics-workflow#2268 [16.0][ADD] stock_move_line_picking_partner
- purchase-workflow#2694 [16.0][IMP]Purchase workflow added to review state & exception fix
Reviewing each other's work helps the whole community move forward. Thank you!
Environment via OCA Neural Reviewer: Minikube + K8s Job + oca-ci/py3.10-odoo16.0 | Odoo 16.0
Automated review by OCA Neural Reviewer + qwen3-coder:30b
Replace ID42 Sistemas with Escodoo in README and CONTRIBUTORS