Skip to content

[18.0][FIX] edi_record_metadata_oca: rename get_metadata (ORM conflict) #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OCA-git-bot merged 1 commit into from
Apr 2, 2026
Merged

[18.0][FIX] edi_record_metadata_oca: rename get_metadata (ORM conflict) #258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions edi_record_metadata_oca/models/edi_exchange_consumer_mixin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,11 @@ def _edi_get_metadata_to_store(self, orig_vals):

def _edi_store_metadata(self, metadata):
if self.origin_exchange_record_id:
self.origin_exchange_record_id.set_metadata(metadata)
self.origin_exchange_record_id.edi_set_metadata(metadata)

@api.model
def _edi_store_metadata_before_create(self, origin_id, metadata):
self.env["edi.exchange.record"].browse(origin_id).set_metadata(metadata)
self.env["edi.exchange.record"].browse(origin_id).edi_set_metadata(metadata)

def _edi_get_metadata(self):
return self.origin_exchange_record_id.get_metadata()
return self.origin_exchange_record_id.edi_get_metadata()
4 changes: 2 additions & 2 deletions edi_record_metadata_oca/models/edi_exchange_record.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ def _compute_metadata_display(self):
for rec in self:
rec.metadata_display = json.dumps(rec.metadata, sort_keys=True, indent=4)

def set_metadata(self, data):
def edi_set_metadata(self, data):
self.metadata = data

def get_metadata(self):
def edi_get_metadata(self):
return self.metadata
6 changes: 3 additions & 3 deletions edi_record_metadata_oca/tests/test_metadata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ def tearDown(self):
super().tearDown()

def test_fields(self):
self.exc_record.set_metadata({"foo": "baz", "bar": "waa"})
self.exc_record.edi_set_metadata({"foo": "baz", "bar": "waa"})
self.assertTrue(self.exc_record.metadata)
self.assertTrue(self.exc_record.metadata_display)

Expand All @@ -44,7 +44,7 @@ def test_no_store(self):
}
)
self.assertFalse(consumer_record._edi_get_metadata())
self.assertFalse(self.exc_record.get_metadata())
self.assertFalse(self.exc_record.edi_get_metadata())

def test_store(self):
vals = {
Expand All @@ -66,4 +66,4 @@ def test_store(self):
"additional": True,
}
self.assertEqual(consumer_record._edi_get_metadata(), expected)
self.assertEqual(self.exc_record.get_metadata(), expected)
self.assertEqual(self.exc_record.edi_get_metadata(), expected)
2 changes: 1 addition & 1 deletion edi_sale_input_oca/tests/test_process.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ def test_metadata(self):
order=dict(origin_exchange_record_id=self.record.id)
),
).create_order(parsed_order, "pricelist")
metadata = self.record.get_metadata()
metadata = self.record.edi_get_metadata()
# Lines are mapped via `edi_id` (coming from `order_line_ref` by default)
line_metadata = metadata["orig_values"]["lines"]["1111"]
for k in (
Expand Down
Loading