fix: rename stale OpenaiConfig references to APIServerConfig#446
Open
skyc1e wants to merge 2 commits intoNousResearch:mainfrom
Open
fix: rename stale OpenaiConfig references to APIServerConfig#446skyc1e wants to merge 2 commits intoNousResearch:mainfrom
skyc1e wants to merge 2 commits intoNousResearch:mainfrom
Conversation
Three environment files still imported the old `OpenaiConfig` name, which was renamed to `APIServerConfig`. This causes an ImportError at module load time, making these environments unusable: - environments/sft_loader_server.py - environments/community/ufc_prediction_env/ufc_server.py - environments/community/ufc_prediction_env/ufc_image_env.py Also adds a lightweight import regression test.
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three environment files still import
OpenaiConfigfromatroposlib.envs.base, but that class was renamed toAPIServerConfig. This causes anImportErrorat module load time, making these environments unusable:environments/sft_loader_server.pyenvironments/community/ufc_prediction_env/ufc_server.pyenvironments/community/ufc_prediction_env/ufc_image_env.pyAll occurrences (imports, type annotations, constructor calls) have been updated to
APIServerConfig. No behavioral change —APIServerConfigaccepts the same fields (model_name,base_url,api_key,num_requests_for_eval).Test plan
atroposlib/tests/test_env_imports.py— parametrized import regression test covering all three fixed modulesOpenaiConfigreferencesAPIServerConfigis re-exported frombase.py(line 47)