[FEAT] Option to customize the hyperparameter tuning behavior of Ray#1286
[FEAT] Option to customize the hyperparameter tuning behavior of Ray#1286JQGoh wants to merge 8 commits intoNixtla:mainfrom
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
aebcea1 to
644a38c
Compare
| # but the search algorithm was already instantiated with a search space. | ||
| # Make sure that `config` does not contain any more parameter definitions | ||
| # - include them in the search algorithm's search space if necessary. | ||
| model_copy = deepcopy(self) |
There was a problem hiding this comment.
@elephaint would love to have your initial round of review on this. This works but I would like to investigate further and hear more from others.
Without this, it raises the mentioned error in the previous failed job like https://github.com/Nixtla/neuralforecast/actions/runs/13796357322/job/38588846450?pr=1286
|
Hi @JQGoh thanks a lot for the PR! I have few comments and questions.
Thanks a lot for your work! |
This happens when we do have conformal predictions intervals setting and we execute fit() multiple times. I have not got time to investigate and fully understood behavior, though the hack can bypass the PR failure. |
|
@JQGoh I tried some approaches on my end to avoid using |
@marcopeix Is there any plan to do a release soon? I try to wrap this up by end of the week if possible |
I want to merge a couple of PRs before making a release (this one included), so no rush! |
| " # but the search algorithm was already instantiated with a search space. \n", | ||
| " # Make sure that `config` does not contain any more parameter definitions \n", | ||
| " # - include them in the search algorithm's search space if necessary.\n", | ||
| " model_copy = deepcopy(self)\n", |
There was a problem hiding this comment.
@JQGoh for determining the conformity scores, isn't it sufficient to temporarily change some parameters of the model so that it doesn't give the error?
I can imagine this creates unnecessary (V)RAM load.
There was a problem hiding this comment.
@elephaint most recent weeks I have been quite well occupied that I have not got more time to have a closer look at this. That was the reason I first tagged you on the deepcopy practice, to have your team's initial review first. When I have more time, I would love to investigate further
remove redundant code
644a38c to
25f2543
Compare
Main objective is to provide a way to customize the hyperparameter tuning behavior of Ray. See issues