fix: update isbinaryfile to fix an issue with protobuf parsing causing hanging#44
Open
dclayton-godaddy wants to merge 1 commit intoNixinova:mainfrom
Open
fix: update isbinaryfile to fix an issue with protobuf parsing causing hanging#44dclayton-godaddy wants to merge 1 commit intoNixinova:mainfrom
dclayton-godaddy wants to merge 1 commit intoNixinova:mainfrom
Conversation
Owner
|
Thanks for the contribution! I have isbinaryfile pinned to v4 because v5 contains a breaking change to the minimum supported node version. So you know if this fix is going to be back ported to v4 at all? |
Author
|
Good catch. Asking... gjtorikian/isBinaryFile#87 |
Author
|
They will accept a back port if I submit one, however I agree that Node.js < 18 is old. Would be nice if maybe we deployed a v3 supporting only newer versions. This would help if we run into future issues with this dependency or others. |
Owner
|
I'm currently working on v3 at #39. I could merge this now, but it wont get released until I'm finished that set of work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are using this package to analyze repositories in order to determine the languages used. Some repositories will hang while processing. This is caused by a bug in the isbinaryfile package in the way it processes files to determine if the file is a protobuf. This package also had a bug in how it handled errors in a callback when promises were used. Both of these bugs were fixed and published in
5.0.5and5.0.6.NPM versions: https://www.npmjs.com/package/isbinaryfile?activeTab=versions
This PR updates
isbinaryfileto5.0.6.